-
Notifications
You must be signed in to change notification settings - Fork 216
Highlight the importance of the Bundle and the need to restart both CP and DP #1990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GTRekter
wants to merge
2
commits into
linkerd:main
Choose a base branch
from
GTRekter:ivanp/cert-manager
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+20
−2
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -21,8 +21,17 @@ primer][mtls-concepts-primer]. | |||||
|
|
||||||
| {{< /note >}} | ||||||
|
|
||||||
| While Linkerd automatically rotates the workload certificates, it cannot | ||||||
| automatically rotate the identity issuer certificate or the trust anchor. | ||||||
| {{< warning >}} | ||||||
|
|
||||||
| Linkerd automatically rotates workload certificates, but it does **not** | ||||||
| rotate the identity issuer certificate or the trust anchor. You can use | ||||||
| third-party tools like cert-manager to automate rotation of those | ||||||
| certificates. However, for critical certificates—such as the | ||||||
| trust anchor, you must manually restart the control-plane components | ||||||
| and all data-plane proxies so they pick up the new trust anchor. | ||||||
|
|
||||||
| {{< /warning >}} | ||||||
|
|
||||||
| Linkerd's out-of-the-box installations generate static self-signed | ||||||
| certificates with a validity of one year but require manual rotation by the | ||||||
| user to prevent expiry. While this setup is convenient for quick start | ||||||
|
|
@@ -418,6 +427,15 @@ the data plane (the proxies) need to be restarted. Since that can't happen | |||||
| instaneously, we need to have both the old trust anchor and the new trust | ||||||
| anchor in the trust bundle until all the restarts have completed. | ||||||
|
|
||||||
| {{< warning >}} | ||||||
|
|
||||||
| This task is criticalas it ensures the old trust anchor remains valid alongside | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| the new one, preventing mTLS validation failures during rotation. After | ||||||
| each rotation, you must also manually update the `linkerd-previous-anchor` | ||||||
| secret with the former trust anchor certificate. | ||||||
|
|
||||||
| {{< /warning >}} | ||||||
|
|
||||||
| trust-manager can do this, but it needs a specific source for _each_ | ||||||
| certificate in the bundle. So we'll start by copying the trust anchor from the | ||||||
| `linkerd-trust-anchor` Secret into a second Secret, `linkerd-previous-anchor`, | ||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.