Highlight the importance of the Bundle and the need to restart both CP and DP #1990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Porta <[email protected]>
Signed-off-by: Ivan Porta <[email protected]>
GTRekter
force-pushed
the
ivanp/cert-manager
branch
from
81a03b2 to
fe8a186
Compare
kflynn
reviewed
Jul 26, 2025
Comment on lines
+26
to
+31
| Linkerd automatically rotates workload certificates, but it does **not** | ||
| rotate the identity issuer certificate or the trust anchor. You can use | ||
| third-party tools like cert-manager to automate rotation of those | ||
| certificates. However, for critical certificates—such as the | ||
| trust anchor, you must manually restart the control-plane components | ||
| and all data-plane proxies so they pick up the new trust anchor. |
There was a problem hiding this comment.
Suggested change
| Linkerd automatically rotates workload certificates, but it does **not** | |
| rotate the identity issuer certificate or the trust anchor. You can use | |
| third-party tools like cert-manager to automate rotation of those | |
| certificates. However, for critical certificates—such as the | |
| trust anchor, you must manually restart the control-plane components | |
| and all data-plane proxies so they pick up the new trust anchor. | |
| Linkerd automatically rotates workload certificates, but it **cannot** | |
| automatically rotate the identity issuer certificate or the trust anchor. | |
| Third-party tools like cert-manager can automate rotation of those | |
| certificates for you, but **read this documentation carefully** to understand | |
| when you need to restart Linkerd components in order to pick up the new | |
| certificates. |
kflynn
reviewed
Jul 26, 2025
|
|
||
| {{< warning >}} | ||
|
|
||
| This task is criticalas it ensures the old trust anchor remains valid alongside |
There was a problem hiding this comment.
Suggested change
| This task is criticalas it ensures the old trust anchor remains valid alongside | |
| This task is critical, since it ensures the old trust anchor remains valid alongside |
kflynn
requested changes
Jul 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two warnings aimed at preventing misunderstandings about cert-manager automatically rotating certificates and clarifying the need for a manual step.