Support FusedLinearCrossEntropy for Gemma2 #320
Merged
+489
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ByronHsu Hi! Can you review this PR please? It thinks to me that this improvement will be very useful) |
ByronHsu
approved these changes
Nov 8, 2024
|
@pansershrek merged. can you try by installing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #127.
Fuse softcapping into cross_entropy kernel, so it can be called by fused linear cross entropy function.
Testing Done
Current monkey patch for Gemma2 can't pass covergence test without flce either. The test is commented out for now.
make testto ensure correctnessmake checkstyleto ensure code stylemake test-convergenceto ensure convergence