Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for jamba model with Liger Kernel #214

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

yubofredwang
Copy link

Summary

Add support for jamba model with Liger Kernel. The following ops can be patched with Liger kernel:

  • RMSNorm
  • cross_entropy
  • swiglu
  • lce_forward

Testing Done

  • Hardware Type: A100-80G-PCIe
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

ByronHsu
ByronHsu previously approved these changes Sep 5, 2024
@yundai424
Copy link
Collaborator

CI is failing, we probably need to set use_mamba_kernels=False in the tests? Or install mamba-ssm in GPU CI

@yubofredwang
Copy link
Author

yubofredwang commented Sep 7, 2024

pip install . '[dev]' fails for this PR after mamba-ssm into the dependecies. The reason is that mamba-ssm has a bug in its setup.py that makes it not PEP 517 compliant(basically torch, packaging, wheel has to be installed before pip install mamba-ssm runs, otherwise it complains no module found error). Similar situation applies to causal-conv1d.

There are fixes done on both repo, but never gets merged in or released:

My current solution is to comment out the tests until the above issues are fixed. However, I have run the convergence test locally. Any other suggestion is highly welcomed.

@@ -27,6 +27,11 @@ dev = [
"seaborn",
]

test = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not good. these two dependencies seem very heavy. is there an alternative?

Copy link
Author

@yubofredwang yubofredwang Sep 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these won't be installed by default though. only when you pip install . '[test]' they are installed.

they are not heavy actually. installation takes about 15 seconds

@ByronHsu ByronHsu mentioned this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants