qemu: experimental support for PPC64LE #3488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
force-pushed
the
ppc64le
branch
3 times, most recently
from
2af5fc9 to
20cd54d
Compare
Signed-off-by: Akihiro Suda <[email protected]>
jandubois
approved these changes
May 3, 2025
| @@ -540,7 +540,8 @@ func Cmdline(ctx context.Context, cfg Config) (exe string, args []string, err er | |||
| } | |||
| } | |||
| } | |||
| if !strings.Contains(string(features.CPUHelp), strings.Split(cpu, ",")[0]) { | |||
| // `qemu-system-ppc64 -help` does not show "max", but it is actually accepted | |||
| if cpu != "max" && !strings.Contains(string(features.CPUHelp), strings.Split(cpu, ",")[0]) { | |||
There was a problem hiding this comment.
Technically it should probably be:
Suggested change
| if cpu != "max" && !strings.Contains(string(features.CPUHelp), strings.Split(cpu, ",")[0]) { | |
| if (*y.arch != limayaml.PPC64LE || cpu != "max") && !strings.Contains(string(features.CPUHelp), strings.Split(cpu, ",")[0]) { |
But I guess we just assume that max is valid for all CPUs now.
Seems to work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage: