-
Notifications
You must be signed in to change notification settings - Fork 652
moved environment variables #3476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Kairvee Vaswani <[email protected]>
```sh | ||
export QEMU_SYSTEM_ARM=/usr/local/bin/qemu-system-arm | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are also riscv64 and s390x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will add and push.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And also ppc64
@@ -107,3 +117,48 @@ This page documents the environment variables used in Lima. | |||
``` | |||
- **Note**: It is an experimental setting and has no guarantees being ever promoted to stable. It may be removed | |||
or changed at any stage of project development. | |||
|
|||
### `QEMU_SYSTEM_X86_64` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this PR is just moving stuff around, but I'm wondering if the documentation should somehow explain that the arch
setting in lima.yaml
determines which environment variable is being used, and that armv7l
is a special case, that is mapped to just arm
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes , I would like to do that , just followed the description as of now but sure !
Should I add it as a note format below the variables or some other suggested way is to be followed?
export QEMU_SYSTEM_X86_64=/usr/local/bin/qemu-system-x86_64 | ||
``` | ||
|
||
### `QEMU_SYSTEM_AARCH64` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the variables should be listed in alphabetical order.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do the changes , thanks
Please squash the commits |
fixes #3459