qemu: tcg: use max by default
#3487
Merged
+32
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 2, 2025
|
This PR is undoing the effect of #931; is that intentional? |
|
I don't think this PR affects whpx |
With this PR you now unconditionally set #931 intentionally prevented the code from setting it to So maybe this is no longer needed, but maybe it should be tested? I realize that QEMU on Windows is currently still WIP, so it won't affect actual users, but we may need to rediscover this fact if we just remove it now. |
|
See also #909 (comment) |
|
Fixed to use |
jandubois
reviewed
May 2, 2025
AkihiroSuda
force-pushed
the
fix-3063
branch
2 times, most recently
from
be16242 to
05f2a4f
Compare
jandubois
reviewed
May 2, 2025
The previous default value `qemu64` for Intel on ARM was unable to boot recent guests as it only supports x86_64 v1 instructions. CentOS Stream 10 is known to need x86_64 v3 or later. Fix issue 3063 Signed-off-by: Akihiro Suda <[email protected]>
|
Thanks for looking at this @AkihiroSuda . Looking forward to being able to build/test Almalinux 10 containers on MacOS via colima 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous default value
qemu64for Intel on ARM was unable to boot recent guests as it only supports x86_64 v1 instructions.CentOS Stream 10 is known to need x86_64 v3 or later.
Fix #3063