fix: settle native Cursor setup failures - #550
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing: this PR's content is absorbed by #551 ( The same Cursor setup-failure settlement already landed in Verification (fetched 2026-09-07): every non-devlog file this PR changes versus its merge-base with |
|
Correction (2026-09-07, post-merge audit): the earlier close comment overstated equivalence. After #559 landed, a fresh check against |
A native Cursor setup failure could emit compatibility completion before the run was admitted to Activity and leave its durable trace header running. Acquisition errors bypass normal lifecycle settlement, so canonical termination alone did not close the header.
Reuse one fallback projection to emit start before compatibility completion, then attempt canonical termination and independently close only the captured still-running trace. The conditional update preserves any result already settled before a later cleanup failure. Diagnostics remain separate from an absent model final; no assistant MESSAGE is fabricated.
Validation: an owned Node ACP peer completes initialize/authenticate then returns exact session/new error -32603 through the real main runtime, SQLite and scoped HTTP SSE. Regression cases cover duplicate replies, ready/settle exceptions, journal/listener faults, stale owners, cancellation, finalizer exceptions and late release. Header and event-order REDs became GREEN. Independent Astra A/B/C reviews passed after strengthening the exact-error and complete-SSE assertions. Final head
40d235d6be4e6de2f058a11d5c8b84e374d311cbpassed 327 focused tests across 28 explicit files, types and 487 documentation counts. Builds, frontend types, assets and strict gates also passed on the identical production tree. Exact-head Tests and Postinstall Platform Checks both succeeded with all jobs green.Stack: based on #546 (
codex/native-activity-journal). Source-only commit:4c5c061f4a3767f978e5d16a6daf16c27aa85b69. No UI or provider SDK changes, release or deployment.