Skip to content

fix: settle native Cursor setup failures - #550

Closed
lidge-jun wants to merge 6 commits into
codex/native-activity-journalfrom
codex/native-activity-setup-errors
Closed

fix: settle native Cursor setup failures#550
lidge-jun wants to merge 6 commits into
codex/native-activity-journalfrom
codex/native-activity-setup-errors

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Sep 6, 2026

Copy link
Copy Markdown
Owner

A native Cursor setup failure could emit compatibility completion before the run was admitted to Activity and leave its durable trace header running. Acquisition errors bypass normal lifecycle settlement, so canonical termination alone did not close the header.

Reuse one fallback projection to emit start before compatibility completion, then attempt canonical termination and independently close only the captured still-running trace. The conditional update preserves any result already settled before a later cleanup failure. Diagnostics remain separate from an absent model final; no assistant MESSAGE is fabricated.

Validation: an owned Node ACP peer completes initialize/authenticate then returns exact session/new error -32603 through the real main runtime, SQLite and scoped HTTP SSE. Regression cases cover duplicate replies, ready/settle exceptions, journal/listener faults, stale owners, cancellation, finalizer exceptions and late release. Header and event-order REDs became GREEN. Independent Astra A/B/C reviews passed after strengthening the exact-error and complete-SSE assertions. Final head 40d235d6be4e6de2f058a11d5c8b84e374d311cb passed 327 focused tests across 28 explicit files, types and 487 documentation counts. Builds, frontend types, assets and strict gates also passed on the identical production tree. Exact-head Tests and Postinstall Platform Checks both succeeded with all jobs green.

Stack: based on #546 (codex/native-activity-journal). Source-only commit: 4c5c061f4a3767f978e5d16a6daf16c27aa85b69. No UI or provider SDK changes, release or deployment.

@coderabbitai

coderabbitai Bot commented Sep 6, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: dd348555-fd49-452f-8c25-67e99b62aa1a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lidge-jun

Copy link
Copy Markdown
Owner Author

Closing: this PR's content is absorbed by #551 (codex/native-activity-dev-reconcile), the single cumulative candidate for dev.

The same Cursor setup-failure settlement already landed in dev via #542 and is reconciled in #551.

Verification (fetched 2026-09-07): every non-devlog file this PR changes versus its merge-base with dev has byte-identical content in the #551 tree, except files renamed or superseded by a later layer (#552#559). No unique change is lost. The branch is kept.

@lidge-jun

Copy link
Copy Markdown
Owner Author

Correction (2026-09-07, post-merge audit): the earlier close comment overstated equivalence. After #559 landed, a fresh check against origin/dev shows this branch's commits are not ancestors of dev — #551 re-authored the donor content as integration commits — and many files diverged through later layers. The functionality is in dev; the original authoring history is only here. This branch is intentionally kept as history, and is excluded from the post-merge branch prune. Do not delete without a separate decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant