Skip to content

feat(web): add runtime Activity, replay, and decision controls - #548

Draft
lidge-jun wants to merge 46 commits into
codex/native-activity-02from
codex/native-activity-web
Draft

feat(web): add runtime Activity, replay, and decision controls#548
lidge-jun wants to merge 46 commits into
codex/native-activity-02from
codex/native-activity-web

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Sep 5, 2026

Copy link
Copy Markdown
Owner

Tool output and commentary appear in a bounded Activity disclosure while the existing message body retains the final answer. Display settings switch between Activity and legacy presentation, and live approval/question controls remain above the composer.

  • Adds shared reduction, owned journal reads, buffered replay, trace links, pagination, scoped caching, and virtual-row recycling. Captured chat/run identity governs admission and history access.
  • Preserves original print answer bytes, explicit empty/null distinctions, Pi final selection, request focus/drafts, and late-run isolation. Manager exposes native/print transport controls for supported providers.
  • Keeps native Cursor cancel-reprompt redirects in one logical run. Setup failures establish canonical ownership before compatibility completion, close the trace header, and retain a safe diagnostic without inventing a model final or saved assistant message.
  • Registers complete rendering callbacks before first-message virtualization and renders promoted terminal rows immediately. Canonical completion now updates the visible Activity row, including error/Stop results and removal of a stale compatibility-only incomplete indication. Genuine recording gaps remain visible.

The stack base is codex/native-activity-02 at ef1fb23bf125513fd9a595d46cded24c18107689. The isolated setup-error source and test oracle from PR550 are included.

Validation: 537 explicitly selected behavioral tests passed at the final candidate, including 10 fresh-virtualization cases and 12 structured-hydration cases with preserved RED/GREEN evidence. Six obsolete source call-location checks were replaced with actual first-user/history/recycling behavior checks. Root/frontend types, server/frontend builds, asset validation, structure counts, and independent source/test/live reviews passed. Actual OS-fenced IAB runs verified Cursor setup error, two redirects in one native process/session, one exact final answer in canonical state/database/UI, actual UI Stop, owner-only reads, and history restoration. Each interval ended with owned processes reaped and unchanged protected-file fingerprints. The final documentation pin and test-only follow-up do not change the exercised production code.

Current follow-up UI evidence is IAB-only. Earlier Electron main/preload, responsive-layout, and Pi checks remain tied to the separately preserved 813d72d34 baseline; they are not relabelled as fresh Electron verification. No merge, release, deployment, or messaging/TUI rollout is included.

Exact-head CI at 184d9826b07e909d3b050626aa98eafcde908da5: Tests and Postinstall Platform Checks, with every job and both aggregates successful.

@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lidge-jun lidge-jun changed the title feat(web): add native Activity display and replay feat(web): add native Activity, replay, and runtime decision controls Sep 5, 2026
@lidge-jun lidge-jun changed the title feat(web): add native Activity, replay, and runtime decision controls feat(web): add runtime Activity, replay, and decision controls Sep 5, 2026
@lidge-jun
lidge-jun marked this pull request as ready for review September 5, 2026 21:49

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 813d72d346

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/core/config.ts
permissions: 'auto',
workingDir: JAW_HOME,
perCli: buildDefaultPerCli(),
presentation: { mode: 'activity' as const },

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Synchronize docs with the enabled Activity default

This makes Activity the default presentation, but README.md still says the mode is a separate follow-on that is not enabled, while root AGENTS.md still describes both the Activity layout and approval UI as future layers. Users and maintainers will therefore follow documentation that directly contradicts the shipped default and controls; update README, AGENTS, CLAUDE, and the architecture guidance with this change.

AGENTS.md reference: AGENTS.md:L182-L183

Useful? React with 👍 / 👎.

Comment thread src/routes/traces.ts
next();
});

app.get('/api/traces/activity-runs', requireAuth, (req, res) => {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Document the new Activity trace endpoints

The new Activity journal endpoints are absent from structure/server_api.md: its Traces row still lists only the three pre-existing routes, and its native-decisions section still says Activity controls are separate. Merely updating the aggregate handler count leaves the public API reference incomplete, so add both Activity read routes and their session/cursor contracts to the synchronized server API documentation.

AGENTS.md reference: structure/AGENTS.md:L10-L11

Useful? React with 👍 / 👎.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-05T21:55:44.475659Z 813d72d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@lidge-jun
lidge-jun marked this pull request as draft September 5, 2026 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant