Implement IFileDialog for Windows #12979
Open
+315
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current implementation of file dialogs has a few bugs and missing features; I've written an implementation using the more modern
IFileDialogapproach.I've retained the old solution, which serves as a fallback on older devices.
There are probably many design issues with the PR (e. g. usage of external libraries like
comdlg32without loading them), but the code itself should be working and feature-complete. I preferred to open the PR early to get feedback, and also not to hold the PR in case I don't have free time until next month :-)Existing Issue(s)
Fixes #12801
Fixes #11519
@AntTheAlchemist Can you confirm that this does indeed fix your issue?