SDL_PROP_FILE_DIALOG_ACCEPT_STRING and SDL_PROP_FILE_DIALOG_CANCEL_STRING not working on windows

[OldSnake22]

Hello,

When I set the SDL_PROP_FILE_DIALOG_ACCEPT_STRING property or SDL_PROP_FILE_DIALOG_CANCEL_STRING property with the SDL_ShowFileDialogWithProperties() function, those properties seems to do nothing, nothing is changed. Everything else is working correctly.

On windows at least. Is this a normal behavior for the windows platform ?

Regards

[slouken]

@Semphriss?

[Semphriss]

Renaming the OK/Cancel buttons is not supported on Windows through the OPENFILENAMEW struct, which SDL currently uses. Generally, cosmetic options are only supported on the platforms that support it. For instance, macOS supports customizing the OK button, but not the Cancel button, and I'm not aware of any workaround.

I believe there has been suggestions to move to IFileDialog, which (among other things) seem to support customizing button labels (IFileDialog2 required for the Cancel button). This would fix this problem on Windows, but keep in mind that other systems may not support all options.

I'm not very familiar with IFileDialog and the principles of modern Windows programming within SDL, and I already informally assigned myself a number of tasks for SDL, so I'm tempted to leave the implementation to somebody else for now. If nobody picks it up, I can give it a try later.

[Semphriss]

I ended up giving it a try and opened #12979, which implements both missing properties.