Switch to new log checksum format #8415
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new log checksum format without the variable-width integer encoding currently used in Boulder. It's still CRC32, just encoded directly into base64 instead of with an extra layer of varint-encoding. Note that despite using the varint encoding, Boulder always writes the full buffer out, so it's zero-padded to 7 bytes. This doesn't switch to using the new format yet, but just accepts it in the log validator. This is change 1/3 in a sequence: * Allow new format * Switch to new format * Remove support for old format. Each of these 3 changes should land one release apart.
Update test case to use the same string
This must be in a release after #8413 It is the 2nd of three changes switching the checksum algorithm.
This was referenced Sep 29, 2025
aarongable
previously approved these changes
Sep 29, 2025
jsha
previously approved these changes
Sep 29, 2025
jprenken
previously approved these changes
Sep 29, 2025
|
Merged main to resolve merge conflicts. This branch is a bit gnarly now though; how would the reviewers feel if I rebased and force-pushed to get a clean single-commit PR here? |
aarongable
approved these changes
Sep 30, 2025
There was a problem hiding this comment.
Eh, the diff is really clean, and everything gets squashed when we merge the PR, so I think it's fine as-is. LGTM for landing any time since the prereq change made it into yesterday's tag.
(I do frequently rebase and force-push changes in situations like this, but only when I've kept them in draft mode up to that point.)
jprenken
approved these changes
Oct 1, 2025
jsha
approved these changes
Oct 1, 2025
|
Waiting to merge until after next week's tag has been cut and fully deployed (likely Oct 9), since this week's tag had to be rolled back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to outputting the new checksum format.
Part of #8414
Warning
Do not merge until #8413 has been successfully deployed, likely Oct 9