Remove support for the old log line checksum format #8416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new log checksum format without the variable-width integer encoding currently used in Boulder. It's still CRC32, just encoded directly into base64 instead of with an extra layer of varint-encoding. Note that despite using the varint encoding, Boulder always writes the full buffer out, so it's zero-padded to 7 bytes. This doesn't switch to using the new format yet, but just accepts it in the log validator. This is change 1/3 in a sequence: * Allow new format * Switch to new format * Remove support for old format. Each of these 3 changes should land one release apart.
Update test case to use the same string
This must be in a release after #8413 It is the 2nd of three changes switching the checksum algorithm.
3 tasks
jprenken
approved these changes
Sep 29, 2025
|
I'm not going to bother to resolve merge conflicts here until after #8415 lands |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to outputting the new checksum format.
Part of #8414
Warning
Do not merge before #8415 has been deployed