Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Started work on inform stage and yaml config stuff #95

Merged
merged 15 commits into from
May 6, 2024
Merged

Started work on inform stage and yaml config stuff #95

merged 15 commits into from
May 6, 2024

Commits on Apr 19, 2024

  1. Started work on inform stage and yaml config stuff

    Raphael Shirley committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    4f39019 View commit details
    Browse the repository at this point in the history

  2. Minor changes to get yaml writing working

    Raphael Shirley committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    1056d99 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Rename infrom to prepare 

    Still questions about whether to inherit from Runner. Could be extended to have multiple configs for each stage possibly.

Can we have a class inheriting from Runner which initiates the sedtolib classes etc which also inherit from Runner?
    Raphael Shirley committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    7073e98 View commit details
    Browse the repository at this point in the history

  2. Renamed inform to prepare in init

    Raphael Shirley committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    7ace807 View commit details
    Browse the repository at this point in the history

  3. Made explicit __all__ in prepare 

    Do we want to move the config functionality eleswhere?
    Raphael Shirley committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    7d83641 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Prepare stage runs 

    I had to add a from_keymap argument. I have used the name config but should probably use keymap consistently
    Raphael Shirley committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    ef4d6db View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Merge branch 'main' into issue/74/consolidate-informer-steps

    Raphael Shirley committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    2c85481 View commit details
    Browse the repository at this point in the history

  2. Minor changes to prepare

    Raphael Shirley committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    b111195 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Prepare and tests running locally 

    I had to add 5mb of files from the data repo to get these passing. Im not sure there is any way around this and opa and others seems to be required.

But I think these tests may be useful as it calls a lot of the python functionality
    Raphael Shirley committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    4d994a5 View commit details
    Browse the repository at this point in the history

  2. Got tests passing locally by setting envirnoment variables explicity … 

    …in test
    Raphael Shirley committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    2858169 View commit details
    Browse the repository at this point in the history

  3. Need Bethermin list for tests

    Raphael Shirley committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    bfc03c1 View commit details
    Browse the repository at this point in the history

  4. REquire all the betthermin seds

    Raphael Shirley committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    efe7294 View commit details
    Browse the repository at this point in the history

  5. Attempt at a minimal Bethermin test

    Raphael Shirley committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    2b5dc37 View commit details
    Browse the repository at this point in the history

  6. Seds to get tests running

    Raphael Shirley committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    3b44ba7 View commit details
    Browse the repository at this point in the history

  7. Removed commented out seds in bethermin

    Raphael Shirley committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    de8da0e View commit details
    Browse the repository at this point in the history