-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Started work on inform stage and yaml config stuff #95
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inform is really rail jargon. In the context of lephare itself we may want to look for a better name, what do you think?
Still questions about whether to inherit from Runner. Could be extended to have multiple configs for each stage possibly. Can we have a class inheriting from Runner which initiates the sedtolib classes etc which also inherit from Runner?
Do we want to move the config functionality eleswhere?
I had to add a from_keymap argument. I have used the name config but should probably use keymap consistently
I will add a short test that calls the prepare code for COSMOS example |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
===========================================
+ Coverage 22.82% 40.84% +18.01%
===========================================
Files 47 48 +1
Lines 5874 5957 +83
Branches 934 934
===========================================
+ Hits 1341 2433 +1092
+ Misses 4533 3524 -1009 ☔ View full report in Codecov by Sentry. |
I had to add 5mb of files from the data repo to get these passing. Im not sure there is any way around this and opa and others seems to be required. But I think these tests may be useful as it calls a lot of the python functionality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a code perspective, this looks good!
I've opened #111 as a note for me to look into the pytest env vars
Working on config overwrites for each type and config writing functionality to simplify interface for rail_lephare.
Closes #74
Code Quality
Bug Fix Checklist
New Feature Checklist
Documentation Change Checklist
Build/CI Change Checklist
Other Change Checklist