Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Started work on inform stage and yaml config stuff #95

Merged
merged 15 commits into from
May 6, 2024

Conversation

raphaelshirley
Copy link
Member

@raphaelshirley raphaelshirley commented Apr 19, 2024

Working on config overwrites for each type and config writing functionality to simplify interface for rail_lephare.

Closes #74

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Bug Fix Checklist

  • My fix includes a new test that breaks as a result of the bug (if possible)
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover my new feature
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Documentation Change Checklist

Build/CI Change Checklist

  • If required or optional dependencies have changed (including version numbers), I have updated the README to reflect this
  • If this is a new CI setup, I have added the associated badge to the README

Other Change Checklist

  • Any new or updated docstrings use the NumPy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover any changes
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Copy link
Member

@johannct johannct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inform is really rail jargon. In the context of lephare itself we may want to look for a better name, what do you think?

Raphael Shirley added 4 commits April 22, 2024 10:04
Still questions about whether to inherit from Runner. Could be extended to have multiple configs for each stage possibly.

Can we have a class inheriting from Runner which initiates the sedtolib classes etc which also inherit from Runner?
Do we want to move the config functionality eleswhere?
I had to add a from_keymap argument. I have used the name config but should probably use keymap consistently
@raphaelshirley
Copy link
Member Author

I will add a short test that calls the prepare code for COSMOS example

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 72.97297% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 40.84%. Comparing base (3d2c9b5) to head (de8da0e).
Report is 16 commits behind head on main.

Files Patch % Lines
src/lephare/prepare.py 69.81% 16 Missing ⚠️
src/lephare/filterSvc.py 80.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #95       +/-   ##
===========================================
+ Coverage   22.82%   40.84%   +18.01%     
===========================================
  Files          47       48        +1     
  Lines        5874     5957       +83     
  Branches      934      934               
===========================================
+ Hits         1341     2433     +1092     
+ Misses       4533     3524     -1009     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Raphael Shirley added 9 commits April 25, 2024 12:07
Copy link
Collaborator

@OliviaLynn OliviaLynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a code perspective, this looks good!

I've opened #111 as a note for me to look into the pytest env vars

@raphaelshirley raphaelshirley merged commit 9bcfee1 into main May 6, 2024
11 checks passed
@raphaelshirley raphaelshirley deleted the issue/74/consolidate-informer-steps branch May 6, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate the "informer" steps of Lephare into a single function
3 participants