-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
196 Potential race condition in read-modify-write PDF vectors in parallel loop in onesource::generatePDF() #206
Changes from 1 commit
7399581
96ab990
8f06ccf
7aee2ff
8221cbd
3cefd8f
5f9c2d4
68a11ac
2c06835
43e923c
d4b956a
5a396b6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -64,11 +64,23 @@ else() | |
add_compile_options("-mno-vzeroupper" "-mavx2" "-floop-unroll-and-jam" ) | ||
endif() | ||
|
||
# only set these flags if testing presence of race conditions : | ||
# https://github.com/google/sanitizers/wiki/ThreadSanitizerCppManual | ||
if(DEFINED ENV{SANITIZE_THREAD}) | ||
message(STATUS "Building with thread sanitizing enabled.") | ||
SET(GCC_COVERAGE_COMPILE_FLAGS "-g -O2 -fsanitize=thread") | ||
SET(GCC_COVERAGE_LINK_FLAGS "-fsanitize=thread") | ||
SET( CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${GCC_COVERAGE_COMPILE_FLAGS}" ) | ||
SET( CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} ${GCC_COVERAGE_LINK_FLAGS}" ) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There's a coding style inconsistency here: space between the parentheses and variable name vs. no space. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. agreed, fixed in #7aee2ff |
||
endif() | ||
|
||
|
||
# only set these flags if in `INCLUDE_COVERAGE` env var is set (to any value) | ||
# on linux/gcc it seems that one needs to run with LD_PRELOAD=/lib/x86_64-linux-gnu/libtsan.so.0 prepended | ||
if(DEFINED ENV{INCLUDE_COVERAGE}) | ||
message(STATUS "Building with code coverage enabled.") | ||
SET(GCC_COVERAGE_COMPILE_FLAGS "-g -O0 -coverage -fprofile-arcs -ftest-coverage") | ||
SET(GCC_COVERAGE_LINK_FLAGS "-coverage -lgcov") | ||
SET(GCC_COVERAGE_COMPILE_FLAGS "-g -O0 -coverage -fprofile-arcs -ftest-coverage -fPIC -pie") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are explicit There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. agreed. Fixed in #7aee2ff |
||
SET(GCC_COVERAGE_LINK_FLAGS "-coverage -lgcov -lpthread") | ||
SET( CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${GCC_COVERAGE_COMPILE_FLAGS}" ) | ||
SET( CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} ${GCC_COVERAGE_LINK_FLAGS}" ) | ||
endif() | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a coding style inconsistency here: space between the parentheses and variable name vs. no space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed, fixed in #7aee2ff