-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
196 Potential race condition in read-modify-write PDF vectors in parallel loop in onesource::generatePDF() #206
Closed
johannct
wants to merge
12
commits into
main
from
197-reduction-operation-being-executed-in-parallel-with-read-modify-write-operation-in-onesourcegeneratepdf
Closed
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
7399581
add the missing arrays as private members in the reduction loop
96ab990
add cmake directive for building with thread sanitizing
8f06ccf
add cmake directive for building with thread sanitizing
7aee2ff
fix coding style and remove flags added by mistake
8221cbd
Merge branch 'main' into 197-reduction-operation-being-executed-in-pa…
johannct 3cefd8f
add cmake directive for building with thread sanitizing
5f9c2d4
Support address sanitizer builds
68a11ac
Merge branch '197-reduction-operation-being-executed-in-parallel-with…
2c06835
Fix comments in CMakeLists.txt
johannct 43e923c
Fix comments in CMakeLists.txt
johannct d4b956a
Merge branch '197-reduction-operation-being-executed-in-parallel-with…
johannct 5a396b6
Merge pull request #210 from lephare-photoz/johannct-patch-1
johannct File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a coding style change unrelated to the pull request, should it have a different commit ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is done automatically by pre-commit, and comes from a previous merge from you that I forced, so I think we can get it through here now.