Fix compiler exception in Visual Studio #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The issue that motivated this PR could also explain why the Windows CMake workflow had to be disabled. I suggest enabling it again after merging this PR. |
|
Closes #74 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
The Visual Studio compiler fails with an exception when running with maximum optimization (default for release builds). This is a regression in the compiler, but it is not likely that it will be fixed anytime soon. Currently this is a show-stopper for building SAF with Visual Studio on Windows.
What are the changes implemented in this PR?
By simply adding a couple of parentheses without any change in the logic, the compiler is happy.