Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the missing checkbox labels #4527

Closed
wants to merge 8 commits into from
Closed

Fixed the missing checkbox labels #4527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4ec85b9
Fixed the missing checkbox labels
shivansh-bhatnagar18 Apr 20, 2024
9fc93de
Added the missing checkbox labels
shivansh-bhatnagar18 May 2, 2024
da9e790
Added the KCheckBox for the MultiSelect Component
shivansh-bhatnagar18 May 4, 2024
9ec4829
Added the KCheckbox Component Wherever neccessary
shivansh-bhatnagar18 May 4, 2024
f3ad4e3
fixed some minor linting errors
shivansh-bhatnagar18 May 4, 2024
cd5459a
Minor Linting Errors
shivansh-bhatnagar18 May 4, 2024
6a51b8d
Fixed the linting issue with the LanguageFilter.vue
shivansh-bhatnagar18 May 20, 2024
00f0fec
Made some minor changes in the KCheckbox Elements
shivansh-bhatnagar18 May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 8 additions & 10 deletions ...curation/contentcuration/frontend/channelList/views/Channel/components/LanguageFilter.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,14 @@
</template>
<template #item="{ item }">
<Checkbox :key="item.id" :input-value="value" :value="item.id" class="mt-0">
<template #label>
<VTooltip bottom lazy>
<template #activator="{ on }">
<div class="text-truncate" style="width: 250px;" v-on="on">
{{ item.name }}
</div>
</template>
<span>{{ item.name }}</span>
</VTooltip>
</template>
<VTooltip bottom lazy>
<template #activator="{ on }">
<div class="text-truncate" style="width: 250px;" v-on="on">
{{ item.name }}
</div>
</template>
<span>{{ item.name }}</span>
</VTooltip>
</Checkbox>
</template>
</VAutocomplete>
Expand Down
20 changes: 10 additions & 10 deletions contentcuration/contentcuration/frontend/shared/views/form/MultiSelect.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,15 @@
{{ getText(item) }}
</VChip>
</template>
<template #item="{ item, tile }">
<Checkbox v-bind="tile.props" class="ma-0">
<template #label>
<span :class="{ notranslate }" :style="getEllipsisStyle()" dir="auto">
{{ getText(item) }}
</span>
</template>
</Checkbox>
<template #item="{ item }">
<KCheckbox
:checked="selections.includes(item)"
:label="getText(item)"
:value="item"
:style="getEllipsisStyle()"
:ripple="false"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't a ripple prop for KCheckbox. Also, it wouldn't seem this is preserving the notranslate class?

:class="{ notranslate }"
/>
</template>
</VSelect>
</template>
Expand All @@ -38,12 +39,11 @@

<script>

import Checkbox from './Checkbox';
import DropdownWrapper from './DropdownWrapper';

export default {
name: 'MultiSelect',
components: { Checkbox, DropdownWrapper },
components: { DropdownWrapper },
// $attrs are rebound to a descendent component
inheritAttrs: false,
props: {
Expand Down