Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the missing checkbox labels #4527

Open
wants to merge 8 commits into
base: unstable
Choose a base branch
from

Conversation

shivansh-bhatnagar18
Copy link
Contributor

Summary

Description of the change(s) you made

I have fixed the missing checkout labels in the content library that were used for filtering out the content for the users to prevent confusion and possible unintended selections. Fixes the issue #4525

Manual verification steps performed

  1. Step 1 ) Checked the working of the component by running the app locally

Screenshots (if applicable)

Screencast.from.2024-04-20.13-49-01.webm

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @shivansh-bhatnagar18 for your interest. Before opening PRs, please ask for assignment first, so that we can help guide you.

Unfortunately, this isn't the correct fix.

@bjester bjester self-assigned this Apr 23, 2024
@MisRob
Copy link
Member

MisRob commented Apr 23, 2024

For context, it may be another regression from #4472, which we already received some fixes for, such as #4512

@shivansh-bhatnagar18
Copy link
Contributor Author

@bjester Actually for the multiselect component (which controls Licenses and Formats) which was easier to replace with the KCheckbox, I replaced the component with the Kolibri Design Systems but for complex components like Languages dropdown which requires Autocomplete and Search Functionalities for which component has been made in Kolibri design systems, I have fixed the missing labels issue.

@bjester bjester self-requested a review May 6, 2024 14:15
:label="getText(item)"
:value="item"
:style="getEllipsisStyle()"
:ripple="false"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't a ripple prop for KCheckbox. Also, it wouldn't seem this is preserving the notranslate class?

@bjester
Copy link
Member

bjester commented May 20, 2024

Hi @shivansh-bhatnagar18,

Seems there's a remaining linting issue on contentcuration/contentcuration/frontend/channelList/views/Channel/components/LanguageFilter.vue

@shivansh-bhatnagar18
Copy link
Contributor Author

Hi @bjester, I fixed the linting issues. There are certain things,

  1. The KCheckbox is previously used in kolibri studio and I see usage of ripple prop for the same. (Attached below) Although I can't find it mentioned in the documentation of Kolibri Design Systems
    Screenshot from 2024-05-21 01-22-53
  2. Now the Kcheckbox also preserves the notranslate class so that it automatically prevents translation

@MisRob
Copy link
Member

MisRob commented May 31, 2024

Hi @shivansh-bhatnagar18, thanks for following up. Regarding the ripple prop usage in another places, that's most likely dead code. There's nothing like that in KCheckbox https://github.com/learningequality/kolibri-design-system/blob/release-v4/lib/KCheckbox.vue so it'd be best to remove it.

@MisRob
Copy link
Member

MisRob commented Jun 11, 2024

Hi @shivansh-bhatnagar18, just chiming in to ask how things are going, is there something we can support with?

@bjester bjester removed their assignment Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants