-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the missing checkbox labels #4527
base: unstable
Are you sure you want to change the base?
Fixed the missing checkbox labels #4527
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @shivansh-bhatnagar18 for your interest. Before opening PRs, please ask for assignment first, so that we can help guide you.
Unfortunately, this isn't the correct fix.
@bjester Actually for the multiselect component (which controls Licenses and Formats) which was easier to replace with the KCheckbox, I replaced the component with the Kolibri Design Systems but for complex components like Languages dropdown which requires Autocomplete and Search Functionalities for which component has been made in Kolibri design systems, I have fixed the missing labels issue. |
:label="getText(item)" | ||
:value="item" | ||
:style="getEllipsisStyle()" | ||
:ripple="false" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There isn't a ripple
prop for KCheckbox
. Also, it wouldn't seem this is preserving the notranslate
class?
Seems there's a remaining linting issue on contentcuration/contentcuration/frontend/channelList/views/Channel/components/LanguageFilter.vue |
Hi @bjester, I fixed the linting issues. There are certain things, |
Hi @shivansh-bhatnagar18, thanks for following up. Regarding the |
Hi @shivansh-bhatnagar18, just chiming in to ask how things are going, is there something we can support with? |
Summary
Description of the change(s) you made
I have fixed the missing checkout labels in the content library that were used for filtering out the content for the users to prevent confusion and possible unintended selections. Fixes the issue #4525
Manual verification steps performed
Screenshots (if applicable)
Screencast.from.2024-04-20.13-49-01.webm
PR process:
CHANGELOG
label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocs
label has been added if this introduces a change that needs to be updated in the user docs?requirements.txt
files also included in this PRStudio-specifc:
notranslate
class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages
,components
, andlayouts
directories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarn
andpip
)