Skip to content

Fix CopyClassModal handle removed coaches #13879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2025
Merged

Fix CopyClassModal handle removed coaches #13879

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b7deae
manually update the state.currentClass when deleting coach from Class…
nucleogenesis Nov 6, 2025
3a014f2
comment explaining the change
nucleogenesis Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions kolibri/plugins/facility/assets/src/modules/classEditManagement/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,13 @@ export default {
},
DELETE_CLASS_COACH(state, id) {
state.classCoaches = state.classCoaches.filter(user => user.id !== id);
// Note that we only do this here because we use `currentClass.coaches` when relevant,
// but there is no equivalent `currentClass.learners` - instead code uses `classLearners`
// where relevant. This is a bit of a stop-gap before this is converted away from Vuex
// in the near future.
if (state.currentClass) {
state.currentClass.coaches = state.currentClass.coaches.filter(u => u.id !== id);
}
},
},
actions: {
Expand Down
Loading