Fix CopyClassModal handle removed coaches #13879
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixing a bug described by @pcenov during his testing on #13865
In the ClassEditPage, when a user would remove a coach, the state for the
currentClasswas not being updated. Manually updating it here fixes the reported issue.This only affected the coaches because, despite there being
classLearnersandclassCoachesproperties on the module's state, the ClassCopyModal fetches the learners for the target class, but uses thecurrentClass.coachesvalue passed into it'sclassToCopyprop.This isn't really the ideal solution, but it'll avoid introducing a bug to our new-to-this-page class copy functionality.
Reviewer guidance
Go to a class's details page and, in general: