-
Notifications
You must be signed in to change notification settings - Fork 825
Finalize the renaming and migration of JS packages in the packages directory #13869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Create kolibri-glob package for reuse across other packages. Clean up kolibri-tools code that has been migrated to kolibri-build.
|
Looks like I missed some cleanup here - will resolve before asking for any review. |
Build Artifacts
|
Migrate all kolibri-tools code there. Remove implicit runtime dependency on kolibri-tools/i18n by bundling additional polyfills into kolibri package.
… kolibri plugins.
Update dependencies.
Update to use a consistent branch.
|
I think all cleanup should have happened now. |
marcellamaki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested the different content types with the sandbox, checked the crowdin workflows by using the updated docs, and had no issues. I have not read through every line of this code, but I suspect that I wouldn't catch things in that way anyways. I think the best bet here is for this to be included in our integration testing for peter to confirm no critical regressions.
Summary
hashipackage tokolibri-sandbox- updates all names except those needed for backwards compatibilityReferences
Fixes #8454
Reviewer guidance
As long as the build passes, this will also need checking of things that use the kolibri-sandbox, such as HTML5, H5P, and Bloompub resources.
I have personally tested upload and download to crowdin, but a double check wouldn't hurt, and a review of the documentation tweaks (by doing what it says in the docs) would be helpful!
Note that I used Claude Code extensively for this, but mostly in terms of code movement, path updating, and renaming things. It also generated the two new Python utilities, for generating language mappings and cleaning up unsupported language locale folders.