Cleanup unused dependencies for kolibri-tools #13877
Merged
+29
−369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Build Artifacts
|
rtibbles
force-pushed
the
cleanup_dependencies
branch
from
531a21b to
d811306
Compare
marcellamaki
approved these changes
Nov 6, 2025
Member
marcellamaki
left a comment
marcellamaki
left a comment
There was a problem hiding this comment.
cleanup looks fine - build builds, tests pass, checks pass, and a quick smoke test of the app looks good ✅ 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I forgot to delete unused dependencies from kolibri-tools, this rectifies that, and possibly will show us if I failed to move any dependencies into other packages that need them.
References
Follow up from #13869
Reviewer guidance
Does linting still run, does the build still build, do tests still run?