Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the UI of ebpf and other svg's for better visibility in dark mode #5819

Closed
wants to merge 7 commits into from
Closed

Improved the UI of ebpf and other svg's for better visibility in dark mode #5819

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f9cdfc6
Update themeStyles.js to support border for svg icons on dark mode
Suswetha6 Aug 15, 2024
a486635
Update meshmap-catalog.js to improve ui of svg's in dark mode
Suswetha6 Aug 15, 2024
53f3ef1
Update CNAME
Suswetha6 Aug 15, 2024
5739177
Update CNAME
Suswetha6 Aug 15, 2024
8f3d202
Update CNAME
Suswetha6 Aug 15, 2024
d6b129c
Delete CNAME
Suswetha6 Aug 15, 2024
0aada74
Update meshmap-catalog.js
Suswetha6 Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion CNAME
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Suswetha6, why did you remove this file?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Suswetha6 Why is this file deleted ? will you revert this change please ?

This file was deleted.

2 changes: 2 additions & 0 deletions src/sections/Meshmap/meshmap-catalog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,8 @@ box-shadow: 0px 6px 5px 0px rgb(0 0 0 / 25%);
max-width:5.6rem;
display:block;
margin: 0 auto;
border: 2px solid ${props => props.theme.borderColorWhiteToTransparent};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove these borders

transition: border-color 0.8s cubic-bezier(0.2, 0.8, 0.2, 1);
}
p{
text-align:center;
Expand Down
2 changes: 2 additions & 0 deletions src/theme/app/themeStyles.js
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will you please sound off why are these theme changes are being introduced ? @Suswetha6

Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,7 @@ const lighttheme = {
bannerDescriptionGradient: "linear-gradient(122.25deg, #00B39F 26.92%, #195E4A 46.51%, #1F787D 74.85%)",
borderGradientTransitionBefore: "linear-gradient(to right bottom, #00b39f, #fff 110%)",
borderGradientTransitionAfter: "linear-gradient(to left top, #00b39f, #fff 120%)",
borderColorWhiteToTransparent: "transparent",

//DarkTheme
DarkTheme: false,
Expand Down Expand Up @@ -449,6 +450,7 @@ export const darktheme = {
bannerDescriptionGradient: "#121212",
borderGradientTransitionBefore: "linear-gradient(to right top, #00b39f, #121212 80%)",
borderGradientTransitionAfter: "linear-gradient(to left top, #00b39f, #121212 100%)",
borderColorWhiteToTransparent: "white",
//DarkTheme
DarkTheme: true,

Expand Down