-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved the UI of ebpf and other svg's for better visibility in dark mode #5819
Conversation
Signed-off-by: Suswetha6 <[email protected]>
Signed-off-by: Suswetha6 <[email protected]>
🚀 Preview for commit a486635 at: https://66bda7570d0bf57b1954d8ab--layer5.netlify.app |
Hey @Suswetha6 please sign the commits using -s , now you need to rebase and squash them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kindly remove these borders and update the svg
@@ -120,6 +120,8 @@ box-shadow: 0px 6px 5px 0px rgb(0 0 0 / 25%); | |||
max-width:5.6rem; | |||
display:block; | |||
margin: 0 auto; | |||
border: 2px solid ${props => props.theme.borderColorWhiteToTransparent}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove these borders
CNAME
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Suswetha6, why did you remove this file?
@narasimha-1511, do we have a svg for this? and @Suswetha6, please fix the DCO sign-off. If you're unaware, read more about it in the contributing guide. |
@Suswetha6, Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes. |
@Suswetha6, please join. The meeting has started. |
@Suswetha6, any luck? |
@Suswetha6, checking again? |
Hey @narasimha-1511 , sorry i was not available. I am not sure how to do the DCO sign-off, i will read about it and do it by eod |
Signed-off-by: Suswetha6 <[email protected]>
🚀 Preview for commit 0aada74 at: https://66c6e5c9cde1b814330e07c2--layer5.netlify.app |
@Suswetha6, any update? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Suswetha6 Why is this file deleted ? will you revert this change please ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will you please sound off why are these theme changes are being introduced ? @Suswetha6
Description
This PR fixes #5070
Notes for Reviewers
I've added a new property in the theme objects in themeStyles.js and updated the css of svg in meshmap section.
Signed commits