Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sistent project to the table #4960

Merged
merged 4 commits into from
Sep 27, 2023
Merged

Add Sistent project to the table #4960

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e60d5c3
Added sistent design project
coder12git Sep 24, 2023
4c090c4
Merge pull request #2 from layer5io/master
coder12git Sep 24, 2023
a0b4609
Change site link
coder12git Sep 25, 2023
e7dea7e
change
coder12git Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/sections/Community/Handbook/repo-data.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,15 @@ export const repo_data = [
maintainers_name: ["Vacant"],
link: ["https://badges.layer5.io"],
repository: "https://github.com/layer5labs/meshery-extensions-packages/"
},
{
project: "Sistent Design System",
image: five,
site: "https://layer5.io/",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
site: "https://layer5.io/",
site: "https://github.com/layer5io/sistent",

As we see the link for the meshery UI has its GitHub Link. Instead of directing users to the Layer5 website, it would be a better option to use this GitHub link.

Please consider this as a suggestion, and there is no obligation to implement it. Share your thoughts on this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, might be good, I add that link because rest others also follows the same pattern :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mohith234 do I need to do any changes?

language: "React.js",
maintainers_name: ["Antonette Caldwell"],
link: ["https://layer5.io/community/members/antonette-caldwell"],
repository: "https://github.com/layer5io/sistent"
}
],
},
Expand Down