Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sistent project to the table #4960

Merged
merged 4 commits into from
Sep 27, 2023
Merged

Conversation

coder12git
Copy link
Member

Description

This PR fixes #4959

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Sep 24, 2023

🚀 Preview for commit 4c090c4 at: https://650fd135bef72e2b253eeda7--layer5.netlify.app

{
project: "Sistent Design System",
image: five,
site: "https://layer5.io/",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
site: "https://layer5.io/",
site: "https://github.com/layer5io/sistent",

As we see the link for the meshery UI has its GitHub Link. Instead of directing users to the Layer5 website, it would be a better option to use this GitHub link.

Please consider this as a suggestion, and there is no obligation to implement it. Share your thoughts on this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, might be good, I add that link because rest others also follows the same pattern :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mohith234 do I need to do any changes?

@saurabh100ni
Copy link
Contributor

let's discuss this item on today's website meeting,
please add this agenda in the docs: https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit#heading=h.69qskjv558bk

Signed-off-by: coder12git <[email protected]>
Signed-off-by: coder12git <[email protected]>
@coder12git
Copy link
Member Author

I have changed the Layer5 site link to GitHub repo link, as discussed today :)

@l5io
Copy link
Contributor

l5io commented Sep 25, 2023

🚀 Preview for commit e7dea7e at: https://65119ea54dc5142f1777f58e--layer5.netlify.app

Copy link
Member

@Mohith234 Mohith234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done @coder12git, LGTM 🚀

Copy link
Contributor

@abhijeetgauravm abhijeetgauravm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution @coder12git

@abhijeetgauravm
Copy link
Contributor

Nicely done @coder12git, LGTM 🚀

LGTM! Thanks for the contribution @coder12git

// @Chadha93

@Chadha93 Chadha93 merged commit 3e432c1 into layer5io:master Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[Handbook] Repository Overview: Add Sistent project to the table
6 participants