Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed full text for "sign into" call to action not visible in light mode #4941

Merged
merged 3 commits into from
Sep 23, 2023

Conversation

VamshiReddy02
Copy link
Contributor

Description

This PR fixes #4931

Notes for Reviewers
I fixed the full text for the "sign into" call to action not visible in light mode. Please let me know if there are any changes to be made.

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Sep 22, 2023

🚀 Preview for commit 824488e at: https://650d6072af9a10277c07e50a--layer5.netlify.app

Copy link
Member

@hirentimbadiya hirentimbadiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @VamshiReddy02 ,

When we move our mouse over the link that is in a light green color, it turns black. However, in layer5, all the links that are green in the dark theme becomes white. So, could you please change the way the link behaves when we hover over it?

link in hover state :
image

Signed-off-by: Vamshi Reddy <[email protected]>
@l5io
Copy link
Contributor

l5io commented Sep 22, 2023

🚀 Preview for commit 4b6acdb at: https://650d83d6bd92d53f52977510--layer5.netlify.app

@VamshiReddy02
Copy link
Contributor Author

Hey @hirentimbadiya, I updated the PR please review it. And let me know if there are any changes to be made.

Copy link
Member

@hirentimbadiya hirentimbadiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VamshiReddy02 , looks good to merge now 👍🏻

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. 🙂

@leecalcote leecalcote merged commit 34395f7 into layer5io:master Sep 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[UX] Learn - full text for "sign into" call to action not visible in light mode
4 participants