Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the full text for "sign into" call to action not visible in light mode #4924

Merged
merged 2 commits into from
Sep 23, 2023

Conversation

VamshiReddy02
Copy link
Contributor

Description

This PR fixes #4919

Notes for Reviewers
I fixed the full text for the "sign into" call to action not visible in light mode. Please let me know if there are any changes to be made.

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Sep 16, 2023

🚀 Preview for commit e52bf97 at: https://65058bcba20b4e08bf8ee747--layer5.netlify.app

Copy link
Member

@Mohith234 Mohith234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution @VamshiReddy02 🚀

@VamshiReddy02
Copy link
Contributor Author

Hey @Chadha93, and @abhijeetgauravm, can you review this PR, and let me know of any changes?

Copy link
Member

@hirentimbadiya hirentimbadiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VamshiReddy02, fix the hover issue for this one as well that you just fixed in issue #4941, because hovering in light mode gives black color, it should be changed to white.

Signed-off-by: Vamshi Reddy <[email protected]>
@l5io
Copy link
Contributor

l5io commented Sep 22, 2023

🚀 Preview for commit 9fe9221 at: https://650ddd6de678fa1e57a8b77c--layer5.netlify.app

Copy link
Member

@Chadha93 Chadha93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you gents

@Chadha93 Chadha93 merged commit adc93ce into layer5io:master Sep 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[UX] Learn - full text for "sign into" call to action not visible in light mode
5 participants