adding-updated design-to-how-it-works-section-akri #4928
Conversation
Signed-off-by: PRANJALRANA11 <[email protected]>
Signed-off-by: PRANJALRANA11 <[email protected]>
|
@abhijeetgauravm thanks for helping |
|
🚀 Preview for commit a709b32 at: https://6507157e851b2749b421947f--layer5.netlify.app |
|
hey @PRANJALRANA11 |
There was a problem hiding this comment.
- These are not the actual screenshots that are required @PRANJALRANA11
- Do check out the Akri integration and replace it with the existing images.
|
But I think in website call meeting lee had said that these are good as there is no screenshot reference provided in spreadsheets |
|
and I think every integration have same screenshot |
|
Both of you fine gentlemen are correct, @Mohith234 and @PRANJALRANA11. Having these screenshots, while not of Akri (which is the ideal - what the issue calls for) puts us in a better position that reusing the same screenshots that most of the rest of the pages have. We could merge this PR as a short-term stop gap until Akri-specific screenshots are taken. |
|
@leecalcote please merge this pr |
|
@PRANJALRANA11 when will you have appropriate screenshots? |
|
Instead of pressuring to merge the PR, how about you provide a genuine fix? Otherwise, remove the "fixes ####" in the PR description so that the issue doesn't close upon merge and unassign yourself from the issue, so that someone else has a chance to sign up to provide an accurate fix. |
|
@leecalcote but in above comment you have said that We could merge this PR as a short-term stop gap until Akri-specific screenshots are taken so that's why I was asking is there is a mistake in my understanding please tell |
|
Yes, you’re right. I’m also recognizing that when this PR is merged, so too will be the issue tracking the continued need for screenshots of the actual technology be closed. Again, you’re asking for the PR to be merged, and still not answering my question, which is precisely the thing that gives me pause here. Your concern is with getting a PR merged and not with resolving the actual issue. This reinforces in my mind that you will not come back to fix the actual issue. So, I will ask again the same question that I just asked… |
|
@leecalcote I think I took that all wrong sorry for that but I was unable to find the Akri integration in the components of playground could you tell me where it is once I find it I just have to make a design with I am right |
|
🚀 Preview for commit ec8e52c at: https://6548f7d39c2cf20f1d129d55--layer5.netlify.app |
Signed-off-by: Pranjal Rana <[email protected]>
|
🚀 Preview for commit 8b51026 at: https://65504b8d51f89631098cf905--layer5.netlify.app |
Description
This PR fixes
Notes for Reviewers
Signed commits