Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: low contrast text and Istio box #4922

Merged
merged 7 commits into from
Oct 14, 2023
Merged

fix: low contrast text and Istio box #4922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8e7b15a
add-member-profile-of-philip
vishalvivekm Jun 26, 2023
6599f85
add-meshery-badge-and-lowercase-suggested-words
vishalvivekm Jun 30, 2023
179e284
fix :low text contrast and istio box
SaxenaShiv Sep 16, 2023
5a98535
fix: low contrast text an istio box
SaxenaShiv Sep 16, 2023
a4f0248
fix: low contrast text an istio box
SaxenaShiv Sep 16, 2023
81357bf
fix: low contrast text an istio box
SaxenaShiv Sep 16, 2023
87c7594
Merge branch 'master' into master
SaxenaShiv Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,4 +90,5 @@ default.profraw
.husky/_/

# Lighthouse CI
.lighthouseci/
.lighthouseci/
.gitpod.yml
11 changes: 11 additions & 0 deletions .gitpod.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# This configuration file was automatically generated by Gitpod.
# Please adjust to your needs (see https://www.gitpod.io/docs/introduction/learn-gitpod/gitpod-yaml)
# and commit this file to your remote git repository to share the goodness with others.

# Learn more from ready-to-use templates: https://www.gitpod.io/docs/introduction/getting-started/quickstart

tasks:
- init: npm install && npm run build && make
command: npm run start


6 changes: 3 additions & 3 deletions src/sections/Learn-Layer5/Chapters/chapters.style.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@ export const ChapterWrapper = styled.div`
}
}

.service-mesh-image-active {
border: 2px solid rgb(0, 179, 159);
}
// .service-mesh-image-active {
// border: 2px solid rgb(0, 179, 159);
// }

.chapter-container {
@media (min-width: 576px) {
Expand Down
2 changes: 1 addition & 1 deletion src/theme/app/themeStyles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ export const darktheme = {
grey313131ToYellowFFF7D8: "#313131",
grey323232ToGreenF3FFFD: "#323232",
grey3C3C3CToGreyF1F1F1: "#3C3C3C",
grey404040ToGreen3C494F: "#404040",
grey404040ToGreen3C494F: "#ffffff66",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Shiv-2712. Where else is this color used? Can you confirm that the use of this color in other locations on the site are not negatively affected?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! This specific color is exclusively employed in Learn-Components, specifically in the file Chapter Style (chapter.style.js). No other file utilizes this particular color variable.

grey404040ToGrey1E2117: "#404040",
grey737373ToGrey222222: "#737373",
grey737373ToGrey4C4A4A: "#737373",
Expand Down