fix: low contrast text and Istio box #4922
Conversation
|
🚀 Preview for commit 379e75a at: https://650575e7a043597a50680e2d--layer5.netlify.app |
|
🚀 Preview for commit c50f5cb at: https://6505f867ef6fec3a97b2c454--layer5.netlify.app |
|
hey @Shiv-2712 |
| @@ -381,7 +381,7 @@ export const darktheme = { | |||
| grey313131ToYellowFFF7D8: "#313131", | |||
| grey323232ToGreenF3FFFD: "#323232", | |||
| grey3C3C3CToGreyF1F1F1: "#3C3C3C", | |||
| grey404040ToGreen3C494F: "#404040", | |||
| grey404040ToGreen3C494F: "#ffffff66", | |||
There was a problem hiding this comment.
Thanks, @Shiv-2712. Where else is this color used? Can you confirm that the use of this color in other locations on the site are not negatively affected?
There was a problem hiding this comment.
Welcome! This specific color is exclusively employed in Learn-Components, specifically in the file Chapter Style (chapter.style.js). No other file utilizes this particular color variable.
|
🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address). To amend the commits in this PR with your signoff using the instructions provided in the DCO check. To configure your dev environment to automatically signoff on your commits in the future, see these instructions.
|
hey @Shiv-2712 it would be good if you just edit the description with like This PR fixes #issue_no |
Signed-off-by: vishalvivekm <[email protected]> Signed-off-by: Shiv Kumar Saxena <[email protected]>
SaxenaShiv
force-pushed
the
master
branch
2 times, most recently
from
1caaf3e to
dfa5e59
Compare
SaxenaShiv
force-pushed
the
master
branch
5 times, most recently
from
670b686 to
a77d4d1
Compare
Signed-off-by: Vivek Vishal <[email protected]> Signed-off-by: Shiv Kumar Saxena <[email protected]>
Signed-off-by: Shiv Kumar Saxena <[email protected]>
Signed-off-by: Shiv Kumar Saxena <[email protected]>
Signed-off-by: Shiv Kumar Saxena <[email protected]>
Signed-off-by: Shiv Kumar Saxena <[email protected]>
Signed-off-by: Shiv Kumar Saxena <[email protected]>
|
🚀 Preview for commit 87c7594 at: https://651c1ffb7992d33137a8eeaf--layer5.netlify.app |
|
@Shiv-2712 Update the PR description with correct mention of the issue |
hey @Shiv-2712 Please mention the issue you are fixing. Here u are fixing #4909. So u should edit the PR description with this. |
|
Hey @Shiv-2712 Let's discuss this on website call today at 5:30 PM IST / 7 AM Central time. Please add this as an agenda item in the meeting minutes |
Description
This PR fixes #4909
The text in the dark mode of the learning paths has been improved to address the visibility issue. Additionally, the border box surrounding the Istio logo has been eliminated.
Signed commits