-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add description prop to books, careers, integrations and workshops pages SEO #4898
Conversation
Signed-off-by: Mohith234 <[email protected]>
🚀 Preview for commit eb5d40d at: https://64ff6ff600d9d548e58e1352--layer5.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Mohith234,
Nice job expanding your previous work into this PR. The changes look good and will help the SEO for current and future MDX pages using these templates.
LGTM!
Cheers,
Randy
Hi @Mohith234, If you wanted expand your previous work even further in another PR, here are some possible tasks: As you mentioned in your notes regarding the
Other mdx page collections that could benefit from better SEO:
Cheers, |
Thanks @randychilau, Will be looking into it and extending to make a PR of that 🙌 |
🚀 Preview for commit d9023f0 at: https://65044eb17d7cc51b242a1af2--layer5.netlify.app |
hey @Mohith234 |
If @randychilau approves, then I approve, too. 👏 |
Description
Follow up PR for #4836 ( Comment )
Notes for Reviewers
books
,careers
,integrations
, andworkshops
pages.news
pages have a fieldsubtitle
as a suitable field for description but when I look into the.mdx
files there are majority of empty strings as subtitles so they were not included here.description
to any other pagesSigned commits