Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta descriptions for service mesh patterns and layer5&hashicoop #5002

Merged
merged 8 commits into from
Nov 6, 2023
Merged

meta descriptions for service mesh patterns and layer5&hashicoop #5002

merged 8 commits into from
Nov 6, 2023

Conversation

AbiodunVlad
Copy link
Contributor

@AbiodunVlad AbiodunVlad commented Oct 4, 2023

Description

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@github-actions github-actions bot added the area/learn Related to /learn section label Oct 4, 2023
@l5io
Copy link
Contributor

l5io commented Oct 4, 2023

🚀 Preview for commit 7e3d922 at: https://651d6f3d65125073293d787c--layer5.netlify.app

@AbiodunVlad
Copy link
Contributor Author

AbiodunVlad commented Oct 4, 2023

Meta descriptions. This fixes issue #4996

@abhijeetgauravm
Copy link
Contributor

hey @AbiodunVlad could you please edit the description with the issue it is fixing? Like This PR fixes #issue_no.

@AbiodunVlad
Copy link
Contributor Author

hey @AbiodunVlad could you please edit the description with the issue it is fixing? Like This PR fixes #issue_no.

Done. Thank you for the lead.

@vishalvivekm
Copy link
Member

@AbiodunVlad
Let's discuss this on website call today at 5:30 PM IST / 7 AM Central time. Pleasde add this as an agenda item in the meeting minutes

Copy link
Member

@Mohith234 Mohith234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AbiodunVlad The changes made don't seem to update the meta description of those webpages when visited in the preview. Do check and fix it.

@Mohith234
Copy link
Member

@AbiodunVlad If you look into the templates/news-single.js the graphql query doesn't seem to extract the description from the .mdx files. Add it there and also pass it into the SEO component as a prop.

For reference check this PR

@github-actions github-actions bot added the area/news A noteworthy article, event, happening label Oct 10, 2023
@l5io
Copy link
Contributor

l5io commented Oct 11, 2023

🚀 Preview for commit 1119f49 at: https://6526ab53c0461f6ab52d093a--layer5.netlify.app

@@ -5,19 +5,30 @@ cover: ./istio-up-and-running.webp
thumbnail: ./istio-up-and-running_top.png
author: "Lee Calcote and Zack Butcher"
abstract: "A must-read for anyone looking to get started with Istio."
description: "Layer5 and HashiCorp join forces to launch a groundbreaking partnership, bringing advanced cloud-native infrastructure solutions for containerized and non-containerized workloads through Meshery and Consul integration. Explore the power of Meshery's support for Consul service mesh, including sample applications, performance management, and experimental support for WebAssembly, demonstrated at DockerCon 2020 for near-native fine-grained traffic control."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description is for the Layer5 and HashiCorp partnership, not for the Istio: Up and Running book.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Mohith234 I have fixed the problem @leecalcote pointed. Kindly give it a final look. Thank you.

@l5io
Copy link
Contributor

l5io commented Oct 16, 2023

🚀 Preview for commit ed1e914 at: https://652d5a72ef45b12bfc04c48e--layer5.netlify.app

@@ -5,19 +5,30 @@ cover: ./istio-up-and-running.webp
thumbnail: ./istio-up-and-running_top.png
author: "Lee Calcote and Zack Butcher"
abstract: "A must-read for anyone looking to get started with Istio."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AbiodunVlad is there a description for this page / book?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, @leecalcote , it was not in the issue.

Copy link
Member

@leecalcote leecalcote Oct 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AbiodunVlad, then don't make changes to this file, please.

Alternatively, you can leave these changes, but need to include a description. Either way...

@@ -5,19 +5,30 @@ cover: ./istio-up-and-running.webp
thumbnail: ./istio-up-and-running_top.png
author: "Lee Calcote and Zack Butcher"
abstract: "A must-read for anyone looking to get started with Istio."

Copy link
Member

@leecalcote leecalcote Oct 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AbiodunVlad, then don't make changes to this file, please.

Alternatively, you can leave these changes, but need to include a description. Either way...

@l5io
Copy link
Contributor

l5io commented Oct 23, 2023

🚀 Preview for commit 9363ce8 at: https://653685f4cdbf46267c7c8dcd--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Oct 26, 2023

🚀 Preview for commit e9eb64b at: https://653a77d6d509bf083f41bf2e--layer5.netlify.app

Signed-off-by: Abiodun Omonijo <[email protected]>
@l5io
Copy link
Contributor

l5io commented Oct 26, 2023

🚀 Preview for commit 35b52ba at: https://653a7f1ed2ee0103c5b16aaa--layer5.netlify.app

@Mohith234
Copy link
Member

@vishalvivekm Good to merge ...

@Mohith234
Copy link
Member

Thanks for contributing @AbiodunVlad 🚀

@Mohith234 Mohith234 merged commit 61a55ee into layer5io:master Nov 6, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/learn Related to /learn section area/news A noteworthy article, event, happening
Development

Successfully merging this pull request may close these issues.

6 participants