-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta descriptions for service mesh patterns and layer5&hashicoop #5002
Conversation
Signed-off-by: Abiodun Omonijo <[email protected]>
🚀 Preview for commit 7e3d922 at: https://651d6f3d65125073293d787c--layer5.netlify.app |
Meta descriptions. This fixes issue #4996 |
hey @AbiodunVlad could you please edit the description with the issue it is fixing? Like This PR fixes #issue_no. |
Done. Thank you for the lead. |
@AbiodunVlad |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AbiodunVlad The changes made don't seem to update the meta description of those webpages when visited in the preview. Do check and fix it.
@AbiodunVlad If you look into the For reference check this PR |
Signed-off-by: Abiodun Omonijo <[email protected]>
Signed-off-by: Abiodun Omonijo <[email protected]>
🚀 Preview for commit 1119f49 at: https://6526ab53c0461f6ab52d093a--layer5.netlify.app |
@@ -5,19 +5,30 @@ cover: ./istio-up-and-running.webp | |||
thumbnail: ./istio-up-and-running_top.png | |||
author: "Lee Calcote and Zack Butcher" | |||
abstract: "A must-read for anyone looking to get started with Istio." | |||
description: "Layer5 and HashiCorp join forces to launch a groundbreaking partnership, bringing advanced cloud-native infrastructure solutions for containerized and non-containerized workloads through Meshery and Consul integration. Explore the power of Meshery's support for Consul service mesh, including sample applications, performance management, and experimental support for WebAssembly, demonstrated at DockerCon 2020 for near-native fine-grained traffic control." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This description is for the Layer5 and HashiCorp partnership, not for the Istio: Up and Running book.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Mohith234 I have fixed the problem @leecalcote pointed. Kindly give it a final look. Thank you.
Signed-off-by: Abiodun Omonijo <[email protected]>
🚀 Preview for commit ed1e914 at: https://652d5a72ef45b12bfc04c48e--layer5.netlify.app |
@@ -5,19 +5,30 @@ cover: ./istio-up-and-running.webp | |||
thumbnail: ./istio-up-and-running_top.png | |||
author: "Lee Calcote and Zack Butcher" | |||
abstract: "A must-read for anyone looking to get started with Istio." | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AbiodunVlad is there a description for this page / book?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, @leecalcote , it was not in the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AbiodunVlad, then don't make changes to this file, please.
Alternatively, you can leave these changes, but need to include a description. Either way...
@@ -5,19 +5,30 @@ cover: ./istio-up-and-running.webp | |||
thumbnail: ./istio-up-and-running_top.png | |||
author: "Lee Calcote and Zack Butcher" | |||
abstract: "A must-read for anyone looking to get started with Istio." | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AbiodunVlad, then don't make changes to this file, please.
Alternatively, you can leave these changes, but need to include a description. Either way...
Signed-off-by: Abiodun Omonijo <[email protected]>
🚀 Preview for commit 9363ce8 at: https://653685f4cdbf46267c7c8dcd--layer5.netlify.app |
Signed-off-by: Abiodun Omonijo <[email protected]>
🚀 Preview for commit e9eb64b at: https://653a77d6d509bf083f41bf2e--layer5.netlify.app |
Signed-off-by: Abiodun Omonijo <[email protected]>
🚀 Preview for commit 35b52ba at: https://653a7f1ed2ee0103c5b16aaa--layer5.netlify.app |
@vishalvivekm Good to merge ... |
Thanks for contributing @AbiodunVlad 🚀 |
Description
This PR fixes #
Notes for Reviewers
Signed commits