-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added description prop to Blog and Resource templates #4836
Conversation
Signed-off-by: Mohith234 <[email protected]>
🚀 Preview for commit a98da0e at: https://64f965b44a56463c4b4d70b4--layer5.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Mohith234 @randychilau 🎉
Yeah since the three pages now have their own descriptions. All these 4 pages now have different description.
For the news though, I wonder if we would want to have specific meta description for each of the news page instead of the default : News and press about Layer5, the cloud native management company. Layer5 the company behind industry-leading, open source software.
@vishalvivekm Having different descriptions for the news articles sounds good to me too. |
🚀 Preview for commit 98afa7a at: https://64f9e5fa7bf4e307e5524057--layer5.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Mohith234, Expanding on @vishalvivekm comment regarding news articles, a follow-up PR could be checking all the other templates to see if there is an appropriate field that could be used as the note: You can review the available For example:
Cheers, |
This is incredibly helpful, @randychilau. |
🚀 Preview for commit 4ead670 at: https://64fae52173876a59c167e4b8--layer5.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, @Mohith234 👏
Description
This PR fixes #4805
Notes for Reviewers
Signed commits