Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added description prop to Blog and Resource templates #4836

Merged
merged 3 commits into from
Sep 9, 2023

Conversation

Mohith234
Copy link
Member

Description

This PR fixes #4805

Notes for Reviewers

  • Added description prop to the graphql query and passed it as a prop to SEO component in the blogs and resources template
  • This solved the duplicate SEO property of the first 3 pages mentioned in the issue description
  • The last page doesn't have any description by default, so the default description is shown. Let me know if I should add one.
  • Thanks to @randychilau for helping me out <3

Signed commits

  • Yes, I signed my commits.

@github-actions github-actions bot added area/blog New posts or new blog functionality area/resources labels Sep 7, 2023
@l5io
Copy link
Contributor

l5io commented Sep 7, 2023

🚀 Preview for commit a98da0e at: https://64f965b44a56463c4b4d70b4--layer5.netlify.app

Copy link
Member

@vishalvivekm vishalvivekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mohith234 @randychilau 🎉
Yeah since the three pages now have their own descriptions. All these 4 pages now have different description.

For the news though, I wonder if we would want to have specific meta description for each of the news page instead of the default : News and press about Layer5, the cloud native management company. Layer5 the company behind industry-leading, open source software.

@Mohith234
Copy link
Member Author

@vishalvivekm Having different descriptions for the news articles sounds good to me too.
Let me know and then I will create a separate issue and work on it if needed.

@l5io
Copy link
Contributor

l5io commented Sep 7, 2023

🚀 Preview for commit 98afa7a at: https://64f9e5fa7bf4e307e5524057--layer5.netlify.app

Copy link
Contributor

@randychilau randychilau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Mohith234,

Nice job on this PR and good notes for the reviewers.

LGTM!

Cheers,
Randy

@randychilau
Copy link
Contributor

Hi @Mohith234,

Expanding on @vishalvivekm comment regarding news articles, a follow-up PR could be checking all the other templates to see if there is an appropriate field that could be used as the description prop for the SEO component, and make the necessary changes.

note: You can review the available frontmatter fields for a template by finding its respective folder in collections and opening a few .mdx files to see which frontmatter field would be appropriate.

For example:

  • for src/templates/career-single.js, by opening the src/collections/careers/digital-marketing-internship/index.mdx file, we can see that the abstract field seems to be a good candidate for the description prop.

Cheers,
Randy

@vishalvivekm
Copy link
Member

Hi @Mohith234,

Expanding on @vishalvivekm comment regarding news articles, a follow-up PR could be checking all the other templates to see if there is an appropriate field that could be used as the description prop for the SEO component, and make the necessary changes.

note: You can review the available frontmatter fields for a template by finding its respective folder in collections and opening a few .mdx files to see which frontmatter field would be appropriate.

For example:

  • for src/templates/career-single.js, by opening the src/collections/careers/digital-marketing-internship/index.mdx file, we can see that the abstract field seems to be a good candidate for the description prop.

Cheers, Randy

This is incredibly helpful, @randychilau.
Thank you most kindly, Sir! :)

@l5io
Copy link
Contributor

l5io commented Sep 8, 2023

🚀 Preview for commit 4ead670 at: https://64fae52173876a59c167e4b8--layer5.netlify.app

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, @Mohith234 👏

@leecalcote leecalcote merged commit 4f8bf36 into layer5io:master Sep 9, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/blog New posts or new blog functionality area/resources type/seo
Development

Successfully merging this pull request may close these issues.

Duplicate meta descriptions
5 participants