feat(world): enable config namespaces key #2880
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7ed17b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 23 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
holic
reviewed
May 30, 2024
holic
reviewed
May 30, 2024
holic
reviewed
May 31, 2024
holic
reviewed
May 31, 2024
holic
reviewed
Jun 7, 2024
holic
reviewed
Jun 7, 2024
| .throws("Can only use `namespaces` with `namespace`, `tables`, or `systems` keys.") | ||
| .type.errors( | ||
| // eslint-disable-next-line max-len | ||
| `Type '{ AnotherOne: { tables: { Example: { schema: { id: string; name: string; age: string; }; key: string[]; }; }; }; }' is not assignable to type '"\`Can only use \`namespaces\` with \`namespace\`, \`tables\`, or \`systems\` keys.`, |
There was a problem hiding this comment.
do we need the whole error or can we reduce this to just "cannot use" bit?
There was a problem hiding this comment.
It will match if we only include part. Why would you not as specific as possible though?
There was a problem hiding this comment.
we're only testing if the error we expect is there (similar to runtime error)
if we change the shape of the object its using, then we have to update the error message too, which is a little annoying
holic
reviewed
Jun 7, 2024
holic
reviewed
Jun 7, 2024
holic
reviewed
Jun 7, 2024
holic
reviewed
Jun 7, 2024
holic
reviewed
Jun 7, 2024
holic
reviewed
Jun 7, 2024
holic
reviewed
Jun 7, 2024
holic
reviewed
Jun 7, 2024
Co-authored-by: Kevin Ingersoll <[email protected]>
Co-authored-by: Kevin Ingersoll <[email protected]>
Co-authored-by: Kevin Ingersoll <[email protected]>
Co-authored-by: Kevin Ingersoll <[email protected]>
holic
force-pushed
the
yonadaaa/fix-tables-without-namespace
branch
from
1254a01
to
7ed17b9
Compare
Merged
|
replaced by #2968 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.