Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump glob #2922

Merged
merged 6 commits into from
Jul 3, 2024
Merged

chore: bump glob #2922

merged 6 commits into from
Jul 3, 2024

Conversation

holic
Copy link
Member

@holic holic commented Jul 3, 2024

encountered some issues with older versions when working on #2880

had to add .sort() everywhere because new versions of glob no longer automatically sort output and instead lean on natural ordering from fs (which is unfortunately non-deterministic)

Copy link

changeset-bot bot commented Jul 3, 2024

🦋 Changeset detected

Latest commit: b868324

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
@latticexyz/abi-ts Patch
@latticexyz/cli Patch
@latticexyz/world-modules Patch
@latticexyz/world Patch
create-mud Patch
@latticexyz/store Patch
mock-game-contracts Patch
@latticexyz/dev-tools Patch
@latticexyz/store-sync Patch
@latticexyz/store-indexer Patch
@latticexyz/block-logs-stream Patch
@latticexyz/common Patch
@latticexyz/config Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/protocol-parser Patch
@latticexyz/query Patch
@latticexyz/react Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@holic holic marked this pull request as ready for review July 3, 2024 12:34
@holic holic requested a review from alvrs as a code owner July 3, 2024 12:34
Copy link
Member

@alvrs alvrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooc what where the issues you encountered with the older version?

@holic
Copy link
Member Author

holic commented Jul 3, 2024

ooc what where the issues you encountered with the older version?

Error: Dynamic require of "fs" is not supported

@holic holic merged commit e49059f into main Jul 3, 2024
14 checks passed
@holic holic deleted the holic/bump-glob branch July 3, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants