-
Notifications
You must be signed in to change notification settings - Fork 64
feat(web-search): add DuckDuckGo search engine #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web-search): add DuckDuckGo search engine #365
Conversation
051778e
to
7795d85
Compare
@Malaydewangan09 Thanks for your contribution! There are some failed tests, could you please check? |
Hey, @Martin7-1 👋 yes, I’ll check this. |
7795d85
to
67874f2
Compare
Seems, more like a rate liming issue with DuckDuckGo 👀 |
@Malaydewangan09, is this PR still a draft or ready to be reviewed by maintainers? Do you still see rate-limiting issues? |
6fa7943
to
530d07e
Compare
@Malaydewangan09 Hi! Thanks for your contribution. Could you please rebase master branch? |
530d07e
to
3e9de5e
Compare
Hey @Martin7-1, it's done, but I see spotless error in other modules too 🤔 Should I apply these?
|
Don't worry about it :) Looks like Github Action successfully passed spotless check. I'll review the PR asap. |
Its still red after adding small retry though 🤔 |
Great! Please ping me if you find ways to solve it. |
@Martin7-1, updated the tests to be more resilient and also took some inspiration from python DuckDuckGo wrapper used in langchain! 🤞 |
Hmm...Looks like it stiil failed |
Humm, looks like a connection timeout now 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Malaydewangan09 I can passed all tests in my local env, looks like the GitHub Action may have some network problem :)
Great job! Thank you!
Please add documents in langchain4j main repo. Thank you! |
Yeah, seems like that. |
Adds support for DuckDuckGo as a web search engine.