Skip to content

feat(web-search): add DuckDuckGo search engine support #3472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat(web-search): add DuckDuckGo search engine support #3472

wants to merge 1 commit into from

Conversation

Malaydewangan09
Copy link
Contributor

Adds support for DuckDuckGo as a web search engine.

closes #3460

@Malaydewangan09 Malaydewangan09 marked this pull request as draft August 4, 2025 04:02
@Malaydewangan09 Malaydewangan09 marked this pull request as ready for review August 4, 2025 04:25
kpavlov
kpavlov reviewed Aug 4, 2025
View reviewed changes
Copy link
Collaborator

@kpavlov kpavlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Malaydewangan09! This is very useful feature.
I have some questions regarding timeouts, parallel requests, http client choice, type safety.

Also, would it be possible to introduce async api method in addition to sync ones? @dliubarskyi , IMO it make sense to require async API for I/O heavy modules by default.

@Malaydewangan09 Malaydewangan09 requested a review from kpavlov August 8, 2025 05:20
@Malaydewangan09 Malaydewangan09 force-pushed the feat/duckduckgo-search-engine branch 5 times, most recently from 4a78bb7 to a6b71cf Compare August 12, 2025 05:20
@Malaydewangan09 Malaydewangan09 force-pushed the feat/duckduckgo-search-engine branch from a6b71cf to 45c7ced Compare August 12, 2025 05:28
@Malaydewangan09
Copy link
Contributor Author

Hey @kpavlov, Seems there's an issue in the CI for the langchain4j-web-search-engine-duckduckgo module, which keeps failing with a parent POM resolution error.
Could you help me figure out what’s going wrong, please?
Thank you!

@dliubarskyi
Copy link
Member

@Malaydewangan09 could you please reopen this PR in the https://github.com/langchain4j/langchain4j-community repo? 🙏

@anna-geller
Copy link

should this one be closed in favor of langchain4j/langchain4j-community#365 (comment) @Malaydewangan09? Do you still see rate-limiting issues?

@Malaydewangan09
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kpavlov kpavlov Awaiting requested review from kpavlov

1 more reviewer

@fdelbrayelle fdelbrayelle fdelbrayelle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE] Add Support for DuckDuckGo Web Search Engine

5 participants

@Malaydewangan09 @dliubarskyi @anna-geller @fdelbrayelle @kpavlov