🎨 Let Curator.validate() throw an error

[falexwolf]

Is part of a sequence of PRs that refactors the curators:

• ✨ Schema-based curators: AnnDataCurator #2418
• ♻️ Re-purpose BaseCurator as Curator and introduce CatCurator #2416
• ♻️ Refactor organism handling in curators #2415
• 🚚 Bulk-rename old-style curators to CatCurator #2413
• 🎨 Self-contained definition of CellxGene schema #2412
• 🚚 Move PertCurator from wetlab here and add CellxGene Curator test #2408
• 🚚 Move CellxGene Curator from cellxgene-lamin here #2403
• ✨ Schema-based curators: DataFrameCurator #2388

---

The new-style curators are now consistent with pydantic and pandera in that they raise informative errors upon .validate() rather than returning False.

Say, there is a typo in the "T cell" label:

with pytest.raises(ln.errors.ValidationError) as err:
    curator.validate()
message = """1 term is not validated: 'T_cell'
    → fix typos, remove non-existent values, or save terms via .add_new_from("cell_type_by_expert")"""
assert err.exconly() == f"lamindb.errors.ValidationError: {message}"

Or a column is missing from a DataFrame (via pandera under-the-hood):

with pytest.raises(ln.errors.ValidationError) as err:
    curator.validate()
message = "column 'cell_type_by_model' not in dataframe. Columns in dataframe: ['date', 'cell_type_by_expert']"
assert err.exconly() == f"lamindb.errors.ValidationError: {message}"

The old-style family of CatCurator classes keeps returning a boolean upon .validate() for backward compatibility.

Also: lamindb.core.exceptions got moved to lamindb.errors.

See internal Slack thread.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.54%. Comparing base (d503387) to head (4625552).
Report is 36 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2417      +/-   ##
==========================================
- Coverage   91.71%   91.54%   -0.18%     
==========================================
  Files          62       63       +1     
  Lines        9138     9569     +431     
==========================================
+ Hits         8381     8760     +379     
- Misses        757      809      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

🚀 Deployed on https://679f79abe005b6d3cb675891--lamindb-qnwk.netlify.app