-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Re-purpose BaseCurator
as Curator
and introduce CatCurator
#2416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaseCurator
as Curator
and enforce properly inherited signatures
BaseCurator
as Curator
and enforce properly inherited signaturesBaseCurator
as Curator
, introduce CatCurator
and consolidate shared logic under CatCurator
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2416 +/- ##
==========================================
- Coverage 91.71% 91.54% -0.17%
==========================================
Files 62 62
Lines 9138 9572 +434
==========================================
+ Hits 8381 8763 +382
- Misses 757 809 +52 ☔ View full report in Codecov by Sentry. |
BaseCurator
as Curator
, introduce CatCurator
and consolidate shared logic under CatCurator
BaseCurator
as Curator
and introduce CatCurator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is part of a sequence of PRs that refactors the curators:
Curator.validate()
throw an error #2417organism
handling in curators #2415CatCurator
#2413CellxGene
schema #2412PertCurator
fromwetlab
here and addCellxGene
Curator
test #2408CellxGene
Curator
fromcellxgene-lamin
here #2403DataFrameCurator
#2388Consolidate under
Curator
Rename
BaseCurator
toCurator
and eliminate the previousCurator
1080aedThe private attributes of
Curator
enable the most basic curation functionality.Consolidate under
CatCurator
99e145bRename
.fields
and._fields
to.categoricals
and._categoricals
, respectivelyThe private attributes of
CatCurator
extendCurator
to enable curating categoricals.DataFrameCatCurator
,AnnDataCatCurator
, andMuDataCatCurator
now all leverage these fields. They also all leverageCatCurator.save_artifact()
.TiledbsomaCatCurator
andSpatialDataCatCurator
both have more custom logic that should be consolidated in another PR.