Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Lower Case and Upper Case Filters #154

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Refactor Lower Case and Upper Case Filters #154

merged 1 commit into from
Aug 13, 2024

Commits on Jun 29, 2024

  1. Refactor Lower Case and Upper Case Filters 

    - Removes `AbstractUnicode` from the inheritance tree and deletes it
- Clean up `File\LowerCase`, `File\UpperCase`, `StringToLower`, `StringToUpper` and `UpperCaseWords` so that they all implement `FilterInterface` directly without any inheritance.

All the filters support an `encoding` option which is re-implemented in each class. Boilerplate is reduced by adding a new internal class `EncodingOption` for consistent handling of encoding options…

Extracted some duplicated file handling code into an internal class `FilterFileContents` that applies a filter to the contents of a file.

This removes the need for `File\LowerCase` to extend `StringToLower` for example.

Signed-off-by: George Steel <[email protected]>
    @gsteel
    gsteel committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    8fa87df View commit details
    Browse the repository at this point in the history