Refactor Lower Case and Upper Case Filters #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes `AbstractUnicode` from the inheritance tree and deletes it - Clean up `File\LowerCase`, `File\UpperCase`, `StringToLower`, `StringToUpper` and `UpperCaseWords` so that they all implement `FilterInterface` directly without any inheritance. All the filters support an `encoding` option which is re-implemented in each class. Boilerplate is reduced by adding a new internal class `EncodingOption` for consistent handling of encoding options… Extracted some duplicated file handling code into an internal class `FilterFileContents` that applies a filter to the contents of a file. This removes the need for `File\LowerCase` to extend `StringToLower` for example. Signed-off-by: George Steel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AbstractUnicodefrom the inheritance tree and deletes itFile\LowerCase,File\UpperCase,StringToLower,StringToUpperandUpperCaseWordsso that they all implementFilterInterfacedirectly without any inheritance.All the filters support an
encodingoption which is re-implemented in each class. Boilerplate is reduced by adding a new internal classEncodingOptionfor consistent handling of encoding options…Extracted some duplicated file handling code into an internal class
FilterFileContentsthat applies a filter to the contents of a file.This removes the need for
File\LowerCaseto extendStringToLowerfor example.