Optimization: Modify Heap read and write related functions
#216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ergs comparison results: |
JulianVentura
changed the title
Heap read and write related functions (wip)Heap read and write related functions
MarcosNicolau
approved these changes
Aug 28, 2024
fkrause98
approved these changes
Aug 28, 2024
JulianVentura
changed the title
Heap read and write related functionsHeap read and write related functions (wip)
Oppen
reviewed
Aug 29, 2024
Comment on lines
500
to
504
| pub fn read_unaligned_from_pointer(&self, pointer: &FatPointer) -> Result<Vec<u8>, HeapError> { | ||
| let mut result = Vec::new(); | ||
| let start = pointer.start + pointer.offset; | ||
| let finish = start + pointer.len; | ||
| for i in start..finish { | ||
| if i as usize >= self.heap.len() { | ||
| return Err(HeapError::ReadOutOfBounds); | ||
| } | ||
| result.push(self.heap[i as usize]); | ||
| } | ||
| Ok(result) | ||
| let start = (pointer.start + pointer.offset) as usize; | ||
| let finish = (start + pointer.len as usize).min(self.heap.len()); | ||
| Ok(self.heap[start..finish].into()) | ||
| } |
There was a problem hiding this comment.
Given there seems to be no error conditions here, maybe just avoid returning Result?
Also, it may be a good idea to return a slice rather than a Vec.
There was a problem hiding this comment.
Yes, that's better.
added 3 commits
August 29, 2024 13:43
JulianVentura
changed the title
Heap read and write related functions (wip)Heap read and write related functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves vm performance by updating
Heapread and write related functions.Inspiration
We are currently iterating and applying
U256operations with aforloop on someHeapfunctions, likeread. It works, but it's not very efficient. We may replace this with functions likeU256::from_big_endianinstead.Changes
Heap::storeHeap::readHeap::expanded_readHeap::read_unaligned_from_pointerResults
heap_read_write.event_spambenches.