Optimization: Modify Heap read and write related functions (wip)
#206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the spec: > Code pages > A code page contains 216216 instructions. They are not writable. > On genesis, code pages are filled as follows: > The contract code is places starting from the address 0. > The rest is filled with a value guaranteed to decode as invalid > instruction. Our code before this fix panics when running the benchmarks due to this discrepancy. The applied fix creates a newtype for code pages that wraps the `Vec<U256>` and returns `U256::zero()` when reading out of bounds, which decodes to an invalid instruction, matching the spec and fixing the `panic`.
ci: fix yml file ci: fix yml file (again) debug: temporarily comment workflow to test ci
ci: remove working directory step ci: add comment ci: use node-setup
ci: fix yarn cache ci: comment bench step for now ci: add working directory for contracts ci: set path for yarn cache ci: fix path to zksync-era yarn.lock
makefile: remove 'touch' command from make target
zksync-era: bump era commit
JulianVentura
changed the title
Heap::read function (wip)Heap read and write related functions (wip)
…to ci/add_era_benches
|
Close because moved to #216 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves vm performance by updating
Heapread and write related functions.Inspiration
We are currently iterating and applying
U256operations with aforloop on someHeapfunctions, likeread. It works, but it's not very efficient. We may replace this with functions likeU256::from_big_endianinstead.Changes
Heap::storeHeap::readHeap::expanded_readHeap::read_unaligned_from_pointerResults
heap_read_write.event_spambenches.