-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate addon for elastic cloud #287
Open
AveryQi115
wants to merge
7
commits into
kubevela:master
Choose a base branch
from
AveryQi115:add-ec-addon
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+100
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
4 tasks
AveryQi115
force-pushed
the
add-ec-addon
branch
from
March 21, 2022 09:27
e7a64d0
to
bca1732
Compare
|
zzxwill
reviewed
Mar 24, 2022
hack/addons/terraform/terraform-provider-scaffold/metadata.yaml
Outdated
Show resolved
Hide resolved
zzxwill
previously approved these changes
Mar 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job. Please also updated docs for kubevela.io.
Signed-off-by: Nicola115 <[email protected]>
Signed-off-by: Nicola115 <[email protected]>
Signed-off-by: Nicola115 <[email protected]>
Signed-off-by: Nicola115 <[email protected]>
Signed-off-by: Nicola115 <[email protected]>
AveryQi115
force-pushed
the
add-ec-addon
branch
from
March 24, 2022 02:42
2b5ff4a
to
37a6875
Compare
Signed-off-by: Nicola115 <[email protected]>
zzxwill
previously approved these changes
Mar 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
…metadata Signed-off-by: Nicola115 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nicola115 [email protected]
Description of your changes
generate addon for elastic cloud
How has this code been tested?
vela addon enable ./addons/terraform-ec EC_API_KEY=xx
Checklist
I have:
[Addon]
or[Trait]
).