Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate addon for elastic cloud #287

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

AveryQi115
Copy link
Contributor

Signed-off-by: Nicola115 [email protected]

Description of your changes

generate addon for elastic cloud

How has this code been tested?

vela addon enable ./addons/terraform-ec EC_API_KEY=xx

image

Checklist

I have:

  • Title of the PR starts with type (e.g. [Addon] or [Trait]).
  • Updated/Added any relevant [documentation] and [examples].
  • Unit/E2E Tests added.

@zzxwill
Copy link
Collaborator

zzxwill commented Mar 15, 2022

@AveryQi115
Copy link
Contributor Author

add resource to further verify the addon.
image

image

zzxwill
zzxwill previously approved these changes Mar 24, 2022
Copy link
Collaborator

@zzxwill zzxwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. Please also updated docs for kubevela.io.

Signed-off-by: Nicola115 <[email protected]>
zzxwill
zzxwill previously approved these changes Mar 24, 2022
Copy link
Collaborator

@zzxwill zzxwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants