Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: enable provider elastic #3453

Merged
merged 2 commits into from
Mar 16, 2022
Merged

Conversation

AveryQi115
Copy link
Contributor

@AveryQi115 AveryQi115 commented Mar 16, 2022

Signed-off-by: Nicola115 [email protected]

Description of your changes

enable provider elastic

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@AveryQi115 AveryQi115 changed the title enable provider ec Fix: enable provider ec Mar 16, 2022
@barnettZQG
Copy link
Collaborator

@Nicola115 I'm sorry, do you introduce about the ec?

@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #3453 (428ba49) into master (040d5e1) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3453      +/-   ##
==========================================
+ Coverage   58.39%   58.42%   +0.02%     
==========================================
  Files         276      276              
  Lines       27300    27300              
==========================================
+ Hits        15942    15950       +8     
+ Misses       9360     9355       -5     
+ Partials     1998     1995       -3     
Flag Coverage Δ
apiserver-unittests 28.00% <ø> (-0.16%) ⬇️
core-unittests 50.27% <ø> (+0.04%) ⬆️
e2e-multicluster-test 26.96% <ø> (+0.02%) ⬆️
e2e-rollout-tests 23.15% <ø> (-0.05%) ⬇️
e2etests 31.13% <ø> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...aits/traitdefinition/traitdefinition_controller.go 65.26% <0.00%> (-7.37%) ⬇️
...ponentdefinition/componentdefinition_controller.go 80.00% <0.00%> (-5.56%) ⬇️
...ev/v1alpha2/core/scopes/healthscope/healthscope.go 66.16% <0.00%> (-3.39%) ⬇️
pkg/cue/definition/template.go 63.22% <0.00%> (-2.90%) ⬇️
...troller/core.oam.dev/v1alpha2/application/apply.go 82.75% <0.00%> (-1.38%) ⬇️
...dev/v1alpha2/application/application_controller.go 85.18% <0.00%> (-0.62%) ⬇️
pkg/apiserver/rest/usecase/application.go 63.50% <0.00%> (-0.59%) ⬇️
pkg/appfile/template.go 56.72% <0.00%> (+0.84%) ⬆️
pkg/controller/utils/capability.go 79.80% <0.00%> (+0.97%) ⬆️
pkg/appfile/parser.go 56.53% <0.00%> (+1.41%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 040d5e1...428ba49. Read the comment docs.

references/cli/def.go Outdated Show resolved Hide resolved
@AveryQi115
Copy link
Contributor Author

@Nicola115 I'm sorry, do you introduce about the ec?

Yes, I've started a PR in catalog to introduce ec provider.(kubevela/catalog#287)

But I have to add a resource to further verify it.

Before using vela def init --provider ec command, I have to enable it in vela cli.

@AveryQi115 AveryQi115 changed the title Fix: enable provider ec Fix: enable provider elastic Mar 16, 2022
@wonderflow wonderflow merged commit 3634ad6 into kubevela:master Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants