Cleanup deprecations

[surik]

What type of PR is this?

/kind cleanup
/kind deprecation

What this PR does / why we need it:

• io/ioutil has been deprecated since Go 1.19.
• rand.Seed has been deprecated since Go 1.20
• strings.Title has been deprecated since Go 1.18
• executor.Stream is deprecated: use StreamWithContext instead (Support cancelable SPDY executor stream kubernetes/kubernetes#103177)
• urfave's cli.NewExitError is deprecated. This function is a duplicate of Exit and will eventually be removed.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

I addressed each issue in its own commit so should be easier to review one by one. I'm happy to squash everything if needed.

I had to exclude some checks for SA1019 as the proposed alternative doesn't look compatible with the protobuf in cri-api.

cmd/crictl/util.go:34:2: SA1019: "github.com/golang/protobuf/jsonpb" is deprecated: Use the "google.golang.org/protobuf/encoding/protojson" package instead. (staticcheck)
        "github.com/golang/protobuf/jsonpb"
        ^
cmd/crictl/util.go:35:2: SA1019: "github.com/golang/protobuf/proto" is deprecated: Use the "google.golang.org/protobuf/proto" package instead. (staticcheck)
        "github.com/golang/protobuf/proto"
        ^

Also, I'm not sure that I went right direction addressing strings.Title.

Does this PR introduce a user-facing change?

NONE

[SergeyKanzhelev]

code changes lgtm

/lgtm

I am not sure why static checks were disabled before, @saschagrunert ok to enable it?

[SergeyKanzhelev]

/remove-kind deprecation

Deprecation kind is used to deprecate features. This is a cleanup

[saschagrunert]

Thank you for the contribution @surik! Unfortunately CI is not happy about it. We could also give golangci-lint a version and config bump if you want.

[surik]

Hi @saschagrunert no need to bump golangci-lint. I had to run it locally on Linux before opening PR. I believe it should be fine now.

[saschagrunert]

@surik the streaming tests seems to fail, I bet it's related to the context.

[saschagrunert]

/approve
/ok-to-test

[surik]

Honesty I do not fully understand what's wrong with the containerd tests. @saschagrunert let me know if you have any ideas.

[saschagrunert]

Ugh, those tests seem to be broken all over the place 🤔

[SergeyKanzhelev]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert, SergeyKanzhelev, surik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[saschagrunert]

Please rebase to the the latest CI changes in.

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[saschagrunert]

@k8s-ci-robot merged without giving GitHub actions a chance to retest 👀