-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tide context race between GitHub actions and prow jobs results in too early merge #30628
Comments
/sig testing |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close not-planned |
@k8s-triage-robot: Closing this issue, marking it as "Not Planned". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What happened:
@k8s-ci-robot (yes, you!) merged PR kubernetes-sigs/cri-tools#1250 right after a rebased force-push by the maintainer, because "all 2 checks passed" (tide and EasyCLA). But we have a bunch of GitHub actions jobs which (sometimes) have a higher cooldown period before getting triggered by GitHub.
The outcome is that the force-push of the maintainer removes the
lgtm
label, but tide still merges it before the GitHub actions are being tiggered:What you expected to happen:
That the GitHub actions jobs run before tide merges them.
How to reproduce it (as minimally and precisely as possible):
No real reproducer available yet, but it happened from time to time over the past years.
Please provide links to example occurrences, if any:
N/A
Anything else we need to know?:
N/A
The text was updated successfully, but these errors were encountered: